Re: [pve-devel] [PATCH widget-toolkit v2] InputPanel: fix column scaling behavior

[Aaron Lauterer <a.lauterer@proxmox.com>]

On 11/17/20 1:05 PM, Dominik Csapak wrote:
> On 11/17/20 12:41 PM, Aaron Lauterer wrote:
>>
>>
>> On 11/17/20 10:29 AM, Dominik Csapak wrote:
>>> some comments inline, looks good otherwise
>>>
>>> On 11/2/20 3:01 PM, Aaron Lauterer wrote:
>>>> When scaling the browsers content either via the browser itself or


[...]

>>>> +            layout: 'hbox',
>>>> +            defaults: {
>>>> +            border: false,
>>>> +            },
>>>
>>> i guess we could add
>>>
>>> layout: 'anchor'
>>>
>>> here too and save 3 lines?
>>
>> instead of the hbox and disabling borders for the 4column layout?
>>
>> Doesn't work for me on Firefox when I do that and check against the PMG -> Configuration -> Spam Detector -> Options -> Languages panel
>>
> 
> hmm? i meant adding using
> 
> layout: 'hbox',
> defaults: {
>      border: false,
>      layout: 'anchor',
>      flex: 1,
> },
> 
> (i just noticed we could also set 'flex: 1' there)
> instead of adding layout: 'anchor' on every child
> 'defaults' corresponds to the default settings of all child items
>

ah now I get it. Yep seems to be working. I will send in v3 with those changes

[...]

>>>>           defaults: {
>>>>               border: false,
>>>>           },
>>>
>>> i guess we would have to change this here to vbox as well?
>>> do we even use 'fieldContainer' anywhere anymore?
>>
>> There are a few places where we have
>>
>> xtype: 'fieldcontainer',
>> extend: 'Ext.form.FieldContainer',
> 
> thats something different

thanks for confirming that

> 
>>
>> if you grep the widget toolkit, pmg-gui and pve-manager repos, but nothing where we set
>>
>> me.useFieldContainer
>>
>> manually. Unless that is some property that extjs is setting automagically.
> 
> i cannot remember, but a short search in extjs source does
> not turn anything up for 'useFieldContainer' so i'd
> say this is dead code and we should/could remove it altogether...
> (i also quickly grepped proxmox-backup, but no use of it there either)
> 

I'll add a separate commit on the v3 to remove that code