Re: [pve-devel] [PATCH pve-manager 1/2] ui: remove excess '}' at the end of snapshot subject

[Fiona Ebner <f.ebner@proxmox.com>]

Minor nit: the commit title could be improved. I'd suggest adding a
second prefix like "ui: guest snapshot: ..." and "... of window title"
instead of the rather unclear "snapshot subject" at the end of the sentence.

Am 30.09.25 um 3:01 PM schrieb Nicolas Frey:
> Noticed one too many curly braces in the Snapshot window title.
> 
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  www/manager6/window/Snapshot.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js
> index 80eaa251..a2134bd3 100644
> --- a/www/manager6/window/Snapshot.js
> +++ b/www/manager6/window/Snapshot.js
> @@ -146,7 +146,7 @@ Ext.define('PVE.window.Snapshot', {
>                  me.vmid,
>                  me.vmname,
>              );
> -            subject = `${guestTypeStr} ${formattedGuestIdentifier} ${gettext('Snapshot')}}`;
> +            subject = `${guestTypeStr} ${formattedGuestIdentifier} ${gettext('Snapshot')}`;
>              me.method = 'POST';
>              me.showTaskViewer = true;
>          } else {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel