From: "Hannes Dürr" <h.duerr@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/nvidia-vgpu-helper v4 0/5] reduce setup steps for nvidia vgpu drivers
Date: Wed, 12 Feb 2025 15:05:12 +0100 [thread overview]
Message-ID: <ed414806-5412-43e8-b9bb-737c21767cb8@proxmox.com> (raw)
In-Reply-To: <da26a5f5-789b-4e45-8a9f-700508004d6d@proxmox.com>
Good point, that will certainly help one or the other.
If nobody has anything against it, I would add it to V5.
On 2/12/25 14:38, Dominik Csapak wrote:
> One super tiny nit (that's IMHO almost bike-shed territory) but
> otherwise LGTM:
>
> Maybe we want to print a short log line before blacklisting the module?
> (though we can always add that later)
>
> So consider this
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-02-12 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 12:27 Hannes Duerr
2025-02-10 12:27 ` [pve-devel] [PATCH pve-nvidia-vgpu-helper v4 1/4] create a debian package to make the installation of Nvidia vGPU drivers more convenient Hannes Duerr
2025-02-10 12:27 ` [pve-devel] [PATCH pve-nvidia-vgpu-helper v4 2/4] debian/control: add dependency for helper script Hannes Duerr
2025-02-10 12:27 ` [pve-devel] [PATCH pve-nvidia-vgpu-helper v4 3/4] add pve-nvidia-vgpu-helper and Makefile to make dependency installation more convenient Hannes Duerr
2025-02-10 12:27 ` [pve-devel] [PATCH pve-nvidia-vgpu-helper v4 4/4] debian: add and install pve-nvidia-sriov systemd template unit file Hannes Duerr
2025-02-10 12:27 ` [pve-devel] [PATCH pve-manager v4 1/1] debian/control: add pve-nvidia-vgpu-helper as dependency Hannes Duerr
2025-02-12 13:38 ` [pve-devel] [PATCH manager/nvidia-vgpu-helper v4 0/5] reduce setup steps for nvidia vgpu drivers Dominik Csapak
2025-02-12 14:05 ` Hannes Dürr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed414806-5412-43e8-b9bb-737c21767cb8@proxmox.com \
--to=h.duerr@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.