From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH v3 proxmox] time: drop trailing space when not showing seconds at end
Date: Thu, 17 Oct 2024 16:40:19 +0200 [thread overview]
Message-ID: <ec70faf4-7fd3-439e-a05a-012e34a9eac3@proxmox.com> (raw)
In-Reply-To: <41eeb7b4-36ca-4983-85a1-cba26e6e686b@proxmox.com>
On 10/17/24 15:16, Thomas Lamprecht wrote:
> applied this one, thanks!
>
> FYI: I found a bug within the Display code, months got printed with the
> "m" unit, which is the unit for minutes. Besides fixing that I also made
> it print "m" for minutes now to have more consistent unit variants (all
> single letter) see the commit message for more details.
>
> I also added a basic module documentation to convey what the format is and
> where it comes from and some basic unit tests, could be surely expanded
> though.
Great! So should we maybe start to switch over time duration output in
the backup client logs to `TimeSpan`s display output?
There are a few places where purely seconds are used.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-10-17 14:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 9:33 [pbs-devel] " Christian Ebner
2024-10-11 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup] partial fix #5560: client: periodically show backup progress Christian Ebner
2024-10-17 15:02 ` [pbs-devel] applied: " Thomas Lamprecht
2024-10-17 15:53 ` Christian Ebner
2024-10-18 7:20 ` Thomas Lamprecht
2024-10-18 7:37 ` Christian Ebner
2024-10-18 7:53 ` Thomas Lamprecht
2024-10-18 8:33 ` Christian Ebner
2024-10-18 12:13 ` Thomas Lamprecht
2024-10-17 13:16 ` [pbs-devel] applied: [PATCH v3 proxmox] time: drop trailing space when not showing seconds at end Thomas Lamprecht
2024-10-17 14:40 ` Christian Ebner [this message]
2024-10-18 12:12 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec70faf4-7fd3-439e-a05a-012e34a9eac3@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal