From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [RFC pmg-yew-quarantine-gui 1/2] buildsys: initialize pwt-assets as submodule automatically
Date: Wed, 29 Oct 2025 09:59:12 +0100 [thread overview]
Message-ID: <ec395fb2-3dae-41c8-bc2c-fa723688431b@proxmox.com> (raw)
In-Reply-To: <20251028163628.79739-2-s.ivanov@proxmox.com>
LGTM
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
On 10/28/25 5:36 PM, Stoiko Ivanov wrote:
> The error-message for the missing submodule and prerequisite is clear,
> but due to parallel make - it gets printed, before the rustc output -
> and is thus not visible when the build fails.
>
> inspired by our zfsonlinux git:
> 63bd3935c (ensure submodule gets initialized on fresh clone and build).
>
> but instead of letting BUILDDIR depend on pwt-assets/README.md it
> depends on the PHONY target (as this will evaluated anyways - and
> short-circuit if the README.md exists)
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> Makefile | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index fdf046c..72937c0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -66,8 +66,11 @@ install: $(COMPILED_OUTPUT) pmg-mobile-index.html.tt
> install -m0644 dist/mobile-yew-style.css $(DESTDIR)$(UIDIR)/css
> install -m0644 pmg-mobile-index.html.tt $(DESTDIR)$(UIDIR)
>
> +.PHONY: submodule
> +submodule:
> + test -f "pwt-assets/README.md" || git submodule update --init
>
> -$(BUILDDIR):
> +$(BUILDDIR): submodule
> rm -rf $@ $@.tmp
> mkdir -p $@.tmp
> cp -a debian/ src/ pwt-assets/ images/ pmg-mobile-index.html.tt Makefile Cargo.toml $@.tmp
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-10-29 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 16:36 [pmg-devel] [RFC pmg-yew-quarantine-gui 0/2] fix direct actions from spamreport links Stoiko Ivanov
2025-10-28 16:36 ` [pmg-devel] [RFC pmg-yew-quarantine-gui 1/2] buildsys: initialize pwt-assets as submodule automatically Stoiko Ivanov
2025-10-29 8:59 ` Dominik Csapak [this message]
2025-10-29 17:27 ` [pmg-devel] applied: " Thomas Lamprecht
2025-10-28 16:36 ` [pmg-devel] [RFC pmg-yew-quarantine-gui 2/2] main view: handle optional quarantine action in spamreport links Stoiko Ivanov
2025-10-29 9:09 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec395fb2-3dae-41c8-bc2c-fa723688431b@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.