* [pve-devel] [PATCH docs] qm: fix hookscript example
@ 2021-02-01 10:06 Aaron Lauterer
2021-02-01 10:47 ` Thomas Lamprecht
2021-04-24 17:45 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Aaron Lauterer @ 2021-02-01 10:06 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
qm.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qm.adoc b/qm.adoc
index 333b2e6..e0cce2b 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1333,7 +1333,7 @@ Hookscripts
You can add a hook script to VMs with the config property `hookscript`.
- qm set 100 -hookscript local:snippets/hookscript.pl
+ qm set 100 --hookscript local:snippets/hookscript.pl
It will be called during various phases of the guests lifetime.
For an example and documentation see the example script under
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH docs] qm: fix hookscript example
2021-02-01 10:06 [pve-devel] [PATCH docs] qm: fix hookscript example Aaron Lauterer
@ 2021-02-01 10:47 ` Thomas Lamprecht
2021-02-01 10:53 ` Aaron Lauterer
2021-04-24 17:45 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2021-02-01 10:47 UTC (permalink / raw)
To: Proxmox VE development discussion, Aaron Lauterer
but this is a style fix only, or? As a single minus always works for options
in CLIHandler based executables (we have no short-opts there).
On 01.02.21 11:06, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> qm.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qm.adoc b/qm.adoc
> index 333b2e6..e0cce2b 100644
> --- a/qm.adoc
> +++ b/qm.adoc
> @@ -1333,7 +1333,7 @@ Hookscripts
>
> You can add a hook script to VMs with the config property `hookscript`.
>
> - qm set 100 -hookscript local:snippets/hookscript.pl
> + qm set 100 --hookscript local:snippets/hookscript.pl
>
> It will be called during various phases of the guests lifetime.
> For an example and documentation see the example script under
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH docs] qm: fix hookscript example
2021-02-01 10:47 ` Thomas Lamprecht
@ 2021-02-01 10:53 ` Aaron Lauterer
0 siblings, 0 replies; 4+ messages in thread
From: Aaron Lauterer @ 2021-02-01 10:53 UTC (permalink / raw)
To: Thomas Lamprecht, Proxmox VE development discussion
On 2/1/21 11:47 AM, Thomas Lamprecht wrote:
>
> but this is a style fix only, or? As a single minus always works for options
> in CLIHandler based executables (we have no short-opts there).
yes it is basically a style fix. It works with one dash. What does not work with one dash though (tested quickly) is the auto completion of the parameter.
>
> On 01.02.21 11:06, Aaron Lauterer wrote:
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> qm.adoc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qm.adoc b/qm.adoc
>> index 333b2e6..e0cce2b 100644
>> --- a/qm.adoc
>> +++ b/qm.adoc
>> @@ -1333,7 +1333,7 @@ Hookscripts
>>
>> You can add a hook script to VMs with the config property `hookscript`.
>>
>> - qm set 100 -hookscript local:snippets/hookscript.pl
>> + qm set 100 --hookscript local:snippets/hookscript.pl
>>
>> It will be called during various phases of the guests lifetime.
>> For an example and documentation see the example script under
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH docs] qm: fix hookscript example
2021-02-01 10:06 [pve-devel] [PATCH docs] qm: fix hookscript example Aaron Lauterer
2021-02-01 10:47 ` Thomas Lamprecht
@ 2021-04-24 17:45 ` Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-04-24 17:45 UTC (permalink / raw)
To: Proxmox VE development discussion, Aaron Lauterer
On 01.02.21 11:06, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> qm.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, but amended the commit message to reflect that is rather due to stylistic
reasons, as it worked before too, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-24 17:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 10:06 [pve-devel] [PATCH docs] qm: fix hookscript example Aaron Lauterer
2021-02-01 10:47 ` Thomas Lamprecht
2021-02-01 10:53 ` Aaron Lauterer
2021-04-24 17:45 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal