From: Dominik Csapak <d.csapak@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup 2/2] server/state: add spawn_internal_task and use it for websockets
Date: Fri, 24 Jul 2020 09:35:41 +0200 [thread overview]
Message-ID: <ebc0b021-4a8d-7ad1-5cf6-7dc2190a94d9@proxmox.com> (raw)
In-Reply-To: <513336870.482.1595575767098@webmail.proxmox.com>
On 7/24/20 9:29 AM, Dietmar Maurer wrote:
>> is a helper to spawn an internal tokio task without it showing up
>> in the task list
>
> Can't we use a normal worker task?
>
we could, but as i wrote in the mail, we'd either have
* 2 visible WorkerTasks per terminal connection (one for the process,
one for the websocket) -> this would be confusing for users..
* would have to make some workertasks invisible somehow (no upid? how to
keep track of it then) -> much work for little gain?
* we would have to refactor the whole terminal handling with termproxy,
so that in only gets started during the websocket connection
-> this is a non-trivial refactoring and would also have to be done on
pve/pmg since they all share some code (at least the gui, which
also has to be aware of some of this)
so i think a small wrapper around tokio::spawn is not so bad
next prev parent reply other threads:[~2020-07-24 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 13:20 [pbs-devel] [PATCH proxmox-backup 1/2] termproxy: let users stop the termproxy task Dominik Csapak
2020-07-23 13:20 ` [pbs-devel] [RFC PATCH proxmox-backup 2/2] server/state: add spawn_internal_task and use it for websockets Dominik Csapak
2020-07-24 7:29 ` Dietmar Maurer
2020-07-24 7:35 ` Dominik Csapak [this message]
2020-07-24 7:37 ` [pbs-devel] [PATCH proxmox-backup 1/2] termproxy: let users stop the termproxy task Dominik Csapak
2020-07-24 10:13 ` [pbs-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebc0b021-4a8d-7ad1-5cf6-7dc2190a94d9@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.