Re: [pdm-devel] applied: [PATCH yew-widget-toolkit/proxmox-api-types/pdm] overhaul remote wizard

[Dominik Csapak <d.csapak@proxmox.com>]

On 12/19/24 13:31, Thomas Lamprecht wrote:
> Am 19.12.24 um 13:09 schrieb Dominik Csapak:
>> reorganize how the wizard is setup, by
>> * first only requiring hostname (+ fingerprint)
>> * then require a name + credentials
>> * then the endpoint list as before
>> * then the summary as before
>>
>> Not super sure about the name for the 'realms' api endpoint, maybe
>> 'scan-realms' or something would be better?
>>
>> The widget toolkit patch is not strictly required, but the layout with
>> the radio buttons is slightly incorrect without it.
>>
>> promxox-yew-widget-toolkit:
>>
>> Dominik Csapak (1):
>>    widget: input panel: use correct column for custom childs
>>
>>   src/widget/input_panel.rs | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> promxox-api-types:
>>
>> Dominik Csapak (1):
>>    add /access/domains GET call
>>
>>   pve-api-types/generate.pl            |  7 +++-
>>   pve-api-types/src/generated/code.rs  | 12 ++++++-
>>   pve-api-types/src/generated/types.rs | 51 ++++++++++++++++++++++++++++
>>   3 files changed, 68 insertions(+), 2 deletions(-)
>>
>> proxmox-datacenter-manager:
>>
>> Dominik Csapak (3):
>>    server: api: add 'realms' add point for PVE
>>    pdm-client: expose `ListRealm` type
>>    ui: restructure wizard to have a better flow
>>
>>   lib/pdm-client/src/lib.rs             |   2 +
>>   server/src/api/pve/mod.rs             |  52 +++-
>>   ui/src/remotes/add_wizard.rs          |  37 ++-
>>   ui/src/remotes/mod.rs                 |   5 +-
>>   ui/src/remotes/wizard_page_connect.rs | 115 ++++-----
>>   ui/src/remotes/wizard_page_info.rs    | 336 ++++++++++++++++++++++----
>>   6 files changed, 415 insertions(+), 132 deletions(-)
>>
> 
> 
> applied series, thanks!
> 
> we might want to place realm and user closer together, maybe besides each
> other, not sure though.
> 
> As unlike the login window, which you probably used as template, one always
> needs to select the realm here (or we auto-select the first/default one too,
> then it might be OK as is)

yeah this was the fastest i could come up with.
I couldn't reuse the realm selector from the login easily
due to that not being able to 'preload' the realms, and i did
not want to query them twice unnecessarily

I'll extend the realm selector from proxmox-yew-comp
with that ability and reuse that then, not sure how long I need for that though...



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel