[pve-devel] applied-series: [PATCH installer v5 0/3] expose zfs arc size setting for all products

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 14.08.24 um 15:25 schrieb Christoph Heiss:
> As suggested by Thomas, leaves the ZFS default if the user never touches
> the setting in the installer (i.e. not writing a modprobe file).
> See also the discussion in v1 [0].
> 
> [0] https://lists.proxmox.com/pipermail/pve-devel/2024-February/061659.html
> 
> Testing
> =======
> 
> Tested the installation of PVE, PBS and PMG, with each once letting the
> arc size setting untouched and once setting it to some specific value.
> Also checked for each whether the correct default value was displayed.
> 
> Afterwards, checked that for PVE the module parameter was always written
> to /etc/modprobe.d/, for PBS that it was only written in case it was
> explicitly set.
> 
> History
> =======
> 
> v4: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063957.html
> v3: https://lists.proxmox.com/pipermail/pve-devel/2024-April/062976.html
> v2: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061667.html
> v1: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060898.html
> 
> Changes v4 -> v5:
>   * rebased on latest master
>   * tui: fixed value not persisting across dialog open/close for non-PVE
> 
> Changes v3 -> v4:
>   * rebased on latest master
> 
> Changes v2 -> v3:
>   * tui: when empty & focused, do not show the placeholder value at all
>   * gui: rework using Gtk3::Adjustment based on Maximilanos suggestion
> 
> Changes v1 -> v2:
>   * rebased on latest master
>   * add placeholder functionality for arc max size in TUI
>   * "emulate" placeholder functionality in GTK on best-effort basis
> 
> Diffstat
> ========
> 
> Christoph Heiss (3):
>   tui: NumericEditView: add optional placeholder value
>   tui: expose arc size setting for zfs bootdisks for all products
>   proxinstall: expose arc size setting for zfs bootdisks for all
>     products
> 
>  Proxmox/Install/RunEnv.pm                   |  3 +-
>  proxinstall                                 | 26 ++++-----
>  proxmox-installer-common/src/options.rs     |  3 +-
>  proxmox-tui-installer/src/views/bootdisk.rs | 48 +++++++++------
>  proxmox-tui-installer/src/views/mod.rs      | 65 +++++++++++++++++++--
>  5 files changed, 108 insertions(+), 37 deletions(-)
> 

applied series, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel