From: Stefan Sterz <s.sterz@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: config: remove duplicate privilege lookup in cached_user_info
Date: Fri, 10 Jun 2022 11:00:20 +0200 [thread overview]
Message-ID: <eb8253a8-c05a-cebd-c1fb-e1d8f007b4ee@proxmox.com> (raw)
In-Reply-To: <20220610085256.2vzgftzhkazoy2np@wobu-vie.proxmox.com>
On 6/10/22 10:52, Wolfgang Bumiller wrote:
> Any reason for the "fix: " prefix in the commit message, though? This
> just seems to remove something redundant and not actually fix an issue?
> Or am I missing something?
>
> Code-wise it seems fine, so I'd apply it, but I'd drop the 'fix' prefix?
>
i can see your point in that this technically doesn't fix a bug. you
can remove it.
my reasoning was that it removes a performance loss (albeit a rather
minor one) and also potential confusion when reviewing this code in
the future. it tripped me up when i looked at it. at the very least it
makes the code here more concise.
-- snip --
next prev parent reply other threads:[~2022-06-10 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 8:13 Stefan Sterz
2022-06-10 8:52 ` Wolfgang Bumiller
2022-06-10 9:00 ` Stefan Sterz [this message]
2022-06-10 9:31 ` [pbs-devel] applied: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb8253a8-c05a-cebd-c1fb-e1d8f007b4ee@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal