all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH proxmox-perl-rs/common] use calendar-events from rust
Date: Thu, 13 Jan 2022 15:45:13 +0100	[thread overview]
Message-ID: <eb347e55-2168-c146-8100-a622ceb835f4@proxmox.com> (raw)
In-Reply-To: <20211201085514.1648428-1-d.csapak@proxmox.com>

On 01.12.21 09:55, Dominik Csapak wrote:
> this series replaces the perl calendar event implementation with the
> one in rust, using proxmox-perl-rs
> 
> the perl interface to 'PVE::CalendarEvent' is the same, but we could
> use PVE::RS::CalendarEvent directly downstream (guest-common/manager)
> but since we need the api type anyway i left that out for now
> 
> with this, we now get all features from the rust implementation
> in perl now, most notably the date part of events which makes it
> possible to have e.g. backups less that once per week (e.g. on the
> first of the month)
> 
> this depends of course on my series to add 'UTC' to the events[0]
> 
> 0: https://lists.proxmox.com/pipermail/pbs-devel/2021-December/004413.html
> 
> proxmox-perl-rs:
> 
> Dominik Csapak (1):
>   pve-rs: add PVE::RS::CalendarEvent
> 
>  pve-rs/Makefile              |  1 +
>  pve-rs/src/calendar_event.rs | 20 ++++++++++++++++++++
>  pve-rs/src/lib.rs            |  1 +
>  3 files changed, 22 insertions(+)
>  create mode 100644 pve-rs/src/calendar_event.rs
> 
> pve-common:
> 
> Dominik Csapak (1):
>   CalendarEvent: use rust implementation
> 
>  src/PVE/CalendarEvent.pm    | 251 +-----------------------------------
>  test/calendar_event_test.pl |  42 +++---
>  2 files changed, 23 insertions(+), 270 deletions(-)
> 

Applied with a followup to actually add `proxmox-time` as dependency in Cargo.toml to
avoid the following compile error:

   Compiling pve-rs v0.5.0 (/root/sources/pve/proxmox-perl-rs/build/pve-rs)
error[E0433]: failed to resolve: use of undeclared crate or module `proxmox_time`
 --> src/calendar_event.rs:9:26
  |
9 |     struct CalendarEvent(proxmox_time::CalendarEvent);
  |                          ^^^^^^^^^^^^ use of undeclared crate or module `proxmox_time`






      parent reply	other threads:[~2022-01-13 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01  8:55 [pve-devel] " Dominik Csapak
2021-12-01  8:55 ` [pve-devel] [PATCH 1/1] pve-rs: add PVE::RS::CalendarEvent Dominik Csapak
2021-12-01  8:55 ` [pve-devel] [PATCH common 1/1] CalendarEvent: use rust implementation Dominik Csapak
2022-01-13 16:20   ` Thomas Lamprecht
2022-01-13 14:45 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb347e55-2168-c146-8100-a622ceb835f4@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal