From: "Laurențiu Leahu-Vlăducu" <l.leahu-vladucu@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] Fix #6231: Removed whitespace-trimming from password entry field
Date: Thu, 13 Mar 2025 09:19:13 +0100 [thread overview]
Message-ID: <ea7f57aa-7813-4c3f-962b-15d1d524506f@proxmox.com> (raw)
In-Reply-To: <20250311115200.50172-1-a.abraham@proxmox.com>
I can confirm that logging in with passwords containing leading or
trailing whitespaces did not work previously, and your patch fixes the
issue.
However, please note that pve_flutter_frontend is the wrong repository,
as this patch is meant to be applied on the proxmox_login_manager
repository instead.
Other than that, please consider:
Reviewed-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
Tested-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
On 11.03.25 12:52, Alexander Abraham wrote:
> A user reported a bug where they were attempting to login into our
> app for PVE and they used a password with two spaces at the end.
> The login failed because of these trailing spaces. I removed the
> string trimming for the password entry field during login so users can
> use passwords that have spaces inside them.
>
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
> lib/proxmox_login_form.dart | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
> index 735bd42..5916563 100644
> --- a/lib/proxmox_login_form.dart
> +++ b/lib/proxmox_login_form.dart
> @@ -464,7 +464,7 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
> //cleaned form fields
> final origin = normalizeUrl(_originController.text.trim());
> final username = _usernameController.text.trim();
> - final String enteredPassword = _passwordController.text.trim();
> + final String enteredPassword = _passwordController.text;
> final String? savedPassword = widget.password;
>
> final password = ticket.isNotEmpty ? ticket : enteredPassword;
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-13 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 11:52 Alexander Abraham
2025-03-13 8:19 ` Laurențiu Leahu-Vlăducu [this message]
2025-03-13 9:05 ` Friedrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea7f57aa-7813-4c3f-962b-15d1d524506f@proxmox.com \
--to=l.leahu-vladucu@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.