all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] applied-series: [PATCH proxmox-offline-mirror 1/2] fix #4445: mirror: subscription: add proxy support
Date: Fri, 27 Jan 2023 12:04:43 +0100	[thread overview]
Message-ID: <ea2e7099-ee16-d7bc-0a1b-3fc8096a7857@proxmox.com> (raw)
In-Reply-To: <1674815039.xmuw5w7ibo.astroid@yuna.none>

Thanks for reviewing my patch!

On 1/27/23 11:25, Fabian Grünbichler wrote:
> I wonder how much work it would be to change that upstream? IIRC we also
> contributed HTTPS_PROXY support to ureq, and this is not the only place where we
> use it and want proper proxy support..
> 

I'll check once I find the time for it.


-- 
- Lukas




  reply	other threads:[~2023-01-27 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 10:40 [pve-devel] " Lukas Wagner
2023-01-19 10:40 ` [pve-devel] [PATCH proxmox-offline-mirror 2/2] docs: document `ALL_PROXY` environment variable Lukas Wagner
2023-01-27 10:25 ` [pve-devel] applied-series: [PATCH proxmox-offline-mirror 1/2] fix #4445: mirror: subscription: add proxy support Fabian Grünbichler
2023-01-27 11:04   ` Lukas Wagner [this message]
2023-02-08 10:01     ` Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea2e7099-ee16-d7bc-0a1b-3fc8096a7857@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal