all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Gabriel Goller <g.goller@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v3 1/4] show optional consent-banner before login
Date: Fri, 4 Apr 2025 20:16:50 +0200	[thread overview]
Message-ID: <e9ca78d8-ac7c-42f7-8c12-f24392116902@proxmox.com> (raw)
In-Reply-To: <20241210161158.383142-2-g.goller@proxmox.com>

Am 10.12.24 um 17:11 schrieb Gabriel Goller:
> Add ConsentBanner variable to html template and populate it from the
> `datacenter.cfg` config file. Add Datacenter option to set the text and
> trigger the popup on login. The max length of the input is 63*1024,
> which is a bit less than the max body size for a api request (64*1024).
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  PVE/Service/pveproxy.pm            | 13 ++++++++++---
>  www/index.html.tpl                 |  3 ++-
>  www/manager6/dc/OptionView.js      |  8 ++++++++
>  www/manager6/window/LoginWindow.js | 12 +++++++++++-
>  4 files changed, 31 insertions(+), 5 deletions(-)
> 
>

applied, thanks!

commented out the onlineHelp for now to avoid build errors while pve-docs is
not yet bumped and increase the maxLength to 64 kiB to match the updated
(reduced) limit in the backend and as the http-server's limit was increased
to 512 kiB recently [0] (not yet bumped though).

[0]: https://git.proxmox.com/?p=pve-http-server.git;a=commitdiff;h=2650923a42c9ea357dc0e663a69294410190cc7c


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-04-04 18:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 16:11 [pve-devel] [PATCH cluster/docs/manager/widget-toolkit v3 0/4] fix #5463: add optional Consent Banner on login Gabriel Goller
2024-12-10 16:11 ` [pve-devel] [PATCH manager v3 1/4] show optional consent-banner before login Gabriel Goller
2025-04-04 18:16   ` Thomas Lamprecht [this message]
2024-12-10 16:11 ` [pve-devel] [PATCH cluster v3 2/4] add consent-text parameter to datacenter config file Gabriel Goller
2025-04-04 17:09   ` [pve-devel] applied: " Thomas Lamprecht
2024-12-10 16:11 ` [pve-devel] [PATCH docs v3 3/4] add consent-banner description Gabriel Goller
2025-04-04 18:06   ` [pve-devel] applied: " Thomas Lamprecht
2024-12-10 16:11 ` [pve-devel] [PATCH widget-toolkit v3 4/4] form: set enforceMaxLength on textareafield Gabriel Goller
2025-02-26 17:59   ` Thomas Lamprecht
2025-02-27 12:37     ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9ca78d8-ac7c-42f7-8c12-f24392116902@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal