all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v5 widget-toolkit 1/3] window/edit: add option to disable reset button
Date: Tue, 13 Apr 2021 09:08:38 +0200	[thread overview]
Message-ID: <e9b84d05-091e-62b5-b36f-c7615dcd86d0@proxmox.com> (raw)
In-Reply-To: <20210215152647.7328-2-a.lauterer@proxmox.com>

On 15.02.21 16:26, Aaron Lauterer wrote:
> Sometimes the reset button does not make sense and the isCreate option
> does not fit as well because with it, the submit button will be enabled
> right away instead of waiting for the form to be valid.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> 
> v1 -> v2 -> v3 -> v4 -> v5: nothing changed
> 
> This helps to reuse the PVE.window.Edit component in a modern viewModel
> and controller way instead of building it all by hand the old way with a
> large initComponent method.
> 
> A possible candidate for refactoring after this would be the
> qemu/HDMove.js component.
> 
> 
>  src/window/Edit.js | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




  reply	other threads:[~2021-04-13  7:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 15:26 [pve-devel] [PATCH v5 series 0/3] Add GUI for disk reassignment Aaron Lauterer
2021-02-15 15:26 ` [pve-devel] [PATCH v5 widget-toolkit 1/3] window/edit: add option to disable reset button Aaron Lauterer
2021-04-13  7:08   ` Thomas Lamprecht [this message]
2021-02-15 15:26 ` [pve-devel] [PATCH v5 manager 2/3] ui: utils: add method to get VM data from resource store Aaron Lauterer
2021-04-18 15:54   ` Thomas Lamprecht
2021-02-15 15:26 ` [pve-devel] [PATCH v5 manager 3/3] ui: qemu: Add disk reassign dialog Aaron Lauterer
2021-04-18 15:57   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9b84d05-091e-62b5-b36f-c7615dcd86d0@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal