From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: lxc: resources: consider rootfs as a disk again
Date: Thu, 7 Apr 2022 15:30:10 +0200 [thread overview]
Message-ID: <e92c8682-fdcf-2f37-3cbb-31f7c5fc1050@proxmox.com> (raw)
In-Reply-To: <20220407121544.159514-1-f.ebner@proxmox.com>
On 07.04.22 14:15, Fabian Ebner wrote:
> Commit fa7980c2 ("ui: lxc resources: switch to vector based font
> awesome icons") seems like an innocent change, but it broke the
> (very brittle) logic here by removing the tdCls for rootfs.
holy moly, didn't really expect that the gui is using css classes as a state
storage, yuck.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> www/manager6/lxc/Resources.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks for catching!
prev parent reply other threads:[~2022-04-07 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:15 [pve-devel] " Fabian Ebner
2022-04-07 13:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e92c8682-fdcf-2f37-3cbb-31f7c5fc1050@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.