From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #5907: ignore conflicting mount options for read-only mounts
Date: Thu, 28 Nov 2024 14:42:41 +0100 [thread overview]
Message-ID: <e8f7d397-9dda-45bc-845d-913fe5a90abd@proxmox.com> (raw)
In-Reply-To: <20241125130908.22076-1-f.schauer@proxmox.com>
Am 25.11.24 um 14:09 schrieb Filip Schauer:
> When mounting volumes as read-only, certain mount options like
> "discard", "lazytime", and "noatime" are either ignored or can cause the
> mount to fail. For example, attempting to mount with "-t zfs" and
> "-o ro,discard" leads to an error: filesystem cannot be mounted due to
> invalid option 'discard'.
>
Things I didn't want to know (but luckily doesn't apply for mountpoints
here ;)):
https://utcc.utoronto.ca/~cks/space/blog/linux/NFSReadonlyAtime
> This commit ensures that only valid mount options, such as "nodev",
> "noexec", and "nosuid", are applied to read-only mounts, avoiding
> potential mount failures.
>
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-28 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 13:09 Filip Schauer
2024-11-28 13:42 ` Fiona Ebner [this message]
2024-11-28 14:56 ` Daniel Kral
2025-02-11 10:17 ` Fiona Ebner
2025-02-11 12:17 ` Thomas Lamprecht
2025-02-11 12:15 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f7d397-9dda-45bc-845d-913fe5a90abd@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.