From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/network v2 0/2] do not apply FRR configuration when reloading host network configuration
Date: Mon, 4 Aug 2025 16:09:21 +0200 [thread overview]
Message-ID: <e8f43829-936f-4b9f-aeba-ad0ec0fa2c48@proxmox.com> (raw)
In-Reply-To: <20250804140152.423614-1-s.hanreich@proxmox.com>
On 04/08/2025 16:01, Stefan Hanreich wrote:
> The FRR apply function was called when omitting the skip_frr parameter, which is
> the case when saving the host network configuration via the Web UI, leading to
> an enabled FRR daemon after saving the network configuration.
>
> In a follow-up we should also consider checking if the previous configuration
> contained FRR entities, but the new one doesn't and disable the FRR daemon in
> this case.
Thanks for the fix! I'm not using fabrics, and after applying these
patches, re-applying the host network configuration doesn't enable+start
frr anymore:
Tested-by: Friedrich Weber <f.weber@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-04 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 14:01 Stefan Hanreich
2025-08-04 14:01 ` [pve-devel] [PATCH pve-manager v2 1/1] api: network: default to not regenerating the frr configuration Stefan Hanreich
2025-08-04 14:01 ` [pve-devel] [PATCH pve-network v2 1/1] sdn: api: rename parameter from skip-frr to regenerate-frr Stefan Hanreich
2025-08-04 14:09 ` Friedrich Weber [this message]
2025-08-04 16:45 ` [pve-devel] applied-series: [PATCH manager/network v2 0/2] do not apply FRR configuration when reloading host network configuration Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f43829-936f-4b9f-aeba-ad0ec0fa2c48@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.