From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shannon Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-storage 1/1] fix #6587: parse snapshot names beginning from the first underscore
Date: Wed, 30 Jul 2025 17:43:01 +0200 [thread overview]
Message-ID: <e8f38b2f-c6cf-41c4-b414-648cb179a81d@proxmox.com> (raw)
In-Reply-To: <20250730103705.98313-2-s.sterz@proxmox.com>
Am 30.07.25 um 12:37 PM schrieb Shannon Sterz:
> Since regular expressions are typically greedy the old regex here
> matched as many underscores as it could (`\S` matches anything that is
> not a whitespace, so also `_`). This lead to an issue where snapshots
> that contained an underscore in their name would be truncated to only
> contain the part of the name after the last underscore.
>
> Use `[^\s_]` to match everything that is not a whitespace and not the
> underscore character.
>
Problem is that right now, disk names may contain an underscore as well,
i.e.
pvesm alloc sharedlvm 100 vm-100-disk_with_underscore.qcow2 1M --format
qcow2
which in particular means from a volume name alone like
snap_vm-100-disk_with_underscore_here_s_some_more.qcow2
it is impossible to know how the disk is called and how the volume is.
We either need to change the naming schema for snapshot and align it
with what we do for the dir plugins or restrict the volume names for
qcow2 on LVM (i.e. disallow _ as part of the volume name).
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-30 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 10:37 Shannon Sterz
2025-07-30 10:37 ` [pve-devel] [PATCH qemu-server 1/1] qemu-server: exit delete early if we cannot find a snapshot Shannon Sterz
2025-07-30 16:32 ` [pve-devel] applied: " Fiona Ebner
2025-07-30 15:43 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f38b2f-c6cf-41c4-b414-648cb179a81d@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.