all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] avoid list context for volume_size_info calls
Date: Tue, 21 Mar 2023 10:38:05 +0100	[thread overview]
Message-ID: <e89cb508-f37f-8845-f6f7-6bd57a3e93a5@proxmox.com> (raw)
In-Reply-To: <20230321091758.17604-1-f.ebner@proxmox.com>

Am 21/03/2023 um 10:17 schrieb Fiona Ebner:
> With the recent pve-storage commit d70d814 ("api: fix get content call response
> type for RBD/ZFS/iSCSI volumes"), the volume_size_info call for RBD in
> list context is much slower than before (from a quick test, about twice as long
> without snapshots, even longer with snapshots and untested, but when using an
> external cluster with image not having the fast-diff feature, it should be worse
> still) and thus increases the likelihood to run into timeouts here.
> 
> None of the callers here actually need the more expensive call, so just
> avoid calling in list context.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QemuServer.pm        | 6 +++---
>  PVE/VZDump/QemuServer.pm | 5 ++++-
>  2 files changed, 7 insertions(+), 4 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2023-03-21  9:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21  9:17 [pve-devel] " Fiona Ebner
2023-03-21  9:38 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e89cb508-f37f-8845-f6f7-6bd57a3e93a5@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal