From: Daniel Kral <d.kral@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH installer] auto: allow a binary executable as the first boot executable
Date: Wed, 11 Dec 2024 10:01:43 +0100 [thread overview]
Message-ID: <e895ed33-24e5-4322-8641-4072ef2f5d87@proxmox.com> (raw)
In-Reply-To: <u4j5k42lx4dmxqt6ilmvgwlhc6yvcnkbvhjy4mrdpcurvqfptl@6crh726nemwl>
On 12/9/24 10:57, Christoph Heiss wrote:
> Why mandate the `Content-Length` header tho? For HTTP/1.1, it is only
> marked SHOULD [0] and for HTTP2, it is actually completely optional [1].
>
> I've just tested it w/ and w/o the patch, both work just fine if no
> `Content-Length` header is sent back.
Thanks for the review and cross checking this!
On 12/9/24 10:57, Christoph Heiss wrote:
> Since the `Content-Length` header isn't actually required, the message
> is misleading.
>
> I wouldn't handle `UnexpectedEof` special here, instead just like any
> other error - since it does not really indicate anything specific.
I agree, I only chose to handle the error message since for binary
response bodies this error was thrown when the library had no knowledge
of the size of the body. I'll send a v2 without handling this error.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-12-11 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 13:24 Daniel Kral
2024-12-09 9:57 ` Christoph Heiss
2024-12-11 9:01 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e895ed33-24e5-4322-8641-4072ef2f5d87@proxmox.com \
--to=d.kral@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.