all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: resource tree: add collapse/expand all button
Date: Tue, 19 Nov 2024 10:36:47 +0100	[thread overview]
Message-ID: <e7cbddda-85aa-40a2-92cf-b4cee00dfd98@proxmox.com> (raw)
In-Reply-To: <491a7dbc-9b2e-46d5-9f09-f4878e140854@proxmox.com>

On 11/19/24 10:30, Thomas Lamprecht wrote:
> Am 19.11.24 um 10:22 schrieb Dominik Csapak:
>> which defaults to expand all, and only if all expanded, collapse all.
>>
>> Changes icon dynamically when nodes expand/collapse.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> if we'd find an icon that would fit for both cases, we could omit the
>> event bubbling probably. If there are many nodes, the 'hasCollapsed'
>> check will trigger more often, iterating over all tree nodes..
> 
> We could also just do two separate buttons, FWIW.

true, but the space there is already a bit limited IMO, and
only one of the buttons makes sense at one point in time


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-11-19  9:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19  9:22 Dominik Csapak
2024-11-19  9:30 ` Thomas Lamprecht
2024-11-19  9:36   ` Dominik Csapak [this message]
2024-11-19  9:39     ` Thomas Lamprecht
2024-11-19  9:41       ` Dominik Csapak
2024-11-19  9:46         ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7cbddda-85aa-40a2-92cf-b4cee00dfd98@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal