all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs/network 0/2] improve behavior of frr service when pre-installed
Date: Tue, 8 Apr 2025 19:07:27 +0200	[thread overview]
Message-ID: <e7bcc506-0cf9-49e5-b3f6-4f88c1ab10cd@proxmox.com> (raw)
In-Reply-To: <20250408163250.355449-1-s.hanreich@proxmox.com>

On 08/04/2025 18:32, Stefan Hanreich wrote:
> Fixes the issue of the FRR service getting started, but not enabled when
> applying an SDN configuration and updates the docs to reflect the new behavior.

- started with fresh ISO with sha256sum:
695c1c9b247e62d851d29d39c3e9399d3a15dd7c1bdca68b357b6bd578ee9925

- set up evpn controller and zone, clicked apply
 => frr.service is disabled but running

- reboot => frr.service is not running

- applied this patch, clicked apply
 => frr.service is now enabled and running

- reboot => frr.service is running

So this looks good to me. I was wondering whether enabling frr may have
any side effects on existing setups, but since we only enable if we
restart anyway, I don't think this should cause any issues.

Consider this

Tested-by: Friedrich Weber <f.weber@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-04-08 17:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 16:32 Stefan Hanreich
2025-04-08 16:32 ` [pve-devel] [PATCH pve-network 1/1] frr: enable frr service on reloading the controller config Stefan Hanreich
2025-04-08 18:43   ` Thomas Lamprecht
2025-04-08 19:39     ` Stefan Hanreich
2025-04-08 19:42     ` Stoiko Ivanov
2025-04-08 19:46       ` Stefan Hanreich
2025-04-08 16:32 ` [pve-devel] [PATCH pve-docs 1/1] sdn: frr update documentation for installing frr package Stefan Hanreich
2025-04-08 16:59 ` [pve-devel] [PATCH docs/network 0/2] improve behavior of frr service when pre-installed Stefan Hanreich
2025-04-08 17:07 ` Friedrich Weber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7bcc506-0cf9-49e5-b3f6-4f88c1ab10cd@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal