From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>,
pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api 1/1] fix #3450: api: add 'filter' parameter to queue DELETE endpoint
Date: Mon, 22 Sep 2025 11:18:10 +0200 [thread overview]
Message-ID: <e7a347fd-3624-4952-9fe8-2c5a95ffa9a5@proxmox.com> (raw)
In-Reply-To: <01437056-8b34-43af-a163-e059006b1889@proxmox.com>
Am 22.09.25 um 10:58 schrieb Dominik Csapak:
> one high level comment and a few comments inline
>
> i get what you want to achieve here and this is what stoiko wrote in the
> bugreport, but from an UX perspective this could be bad. Since the
> mails shown on the gui might not match what will be deleted (e.g. new mails came in, in the meantime)
>
> would it maybe make more sense to have an approach with giving a list
> of ids to the backend? (@stoiko ?)
That would be safer, as long as it can also handle at least 1k of mails
being processed I'd be fine with that.
An alternative could be passing a cutoff timestamp from the newest mail
selected along, but an explicit list naturally is slightly simpler to
handle and to debug, so mostly just mentioning it for the sake of
completeness.
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-09-22 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 14:50 [pmg-devel] [PATCH pmg-api/pmg-gui 0/2] add support to delete multiple queue entries at once Hannes Laimer
2025-09-19 14:50 ` [pmg-devel] [PATCH pmg-api 1/1] fix #3450: api: add 'filter' parameter to queue DELETE endpoint Hannes Laimer
2025-09-22 8:58 ` Dominik Csapak
2025-09-22 9:18 ` Thomas Lamprecht [this message]
2025-09-22 10:09 ` Stoiko Ivanov
2025-09-22 10:15 ` Hannes Laimer
2025-09-22 9:19 ` Thomas Lamprecht
2025-09-19 14:50 ` [pmg-devel] [PATCH pmg-gui 1/1] fix #3450: ui: add button to delete all queue entries matching a filter Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7a347fd-3624-4952-9fe8-2c5a95ffa9a5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.