From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] content-dirs check: silently skip paths that cannot be resolved
Date: Thu, 15 Jun 2023 14:19:53 +0200 [thread overview]
Message-ID: <e778fdbf-8c27-4334-2502-fbe5d97fa75f@proxmox.com> (raw)
In-Reply-To: <20230615113658.392066-1-f.weber@proxmox.com>
Am 15/06/2023 um 13:36 schrieb Friedrich Weber:
> Since commit 8e623a2930f7aee4b3309b1f297613a250ee4698, the inequality
> check for content-dirs prints a warning if a content directory path
> could not be resolved, i.e., if `abs_path` returns undef. Among other
> things, `abs_path` returns undef if the path has an inner (= any but
> last) component that does not exist. This can happen for a storage
> with content type `iso,vztmpl` and `create-subdirs` set to 0, in case
> `template/` does not exist. In this case, the warnings printed by
> pvestatd are quite noisy.
>
> As missing content directories are not a problem per se, remove the
> warning and just ignore the directory during the inequality check.
>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> src/PVE/Storage/Plugin.pm | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-06-15 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 11:36 [pve-devel] " Friedrich Weber
2023-06-15 12:19 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e778fdbf-8c27-4334-2502-fbe5d97fa75f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal