From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing value for target store upon edit of local sync job
Date: Wed, 29 Nov 2023 09:02:12 +0100 [thread overview]
Message-ID: <e75f1e38-2a2f-46d8-9351-f3ee0bf486af@proxmox.com> (raw)
In-Reply-To: <8809f49c-102a-49c2-b883-5634dc86f0b0@proxmox.com>
Am 29.11.23 um 08:42 schrieb Fiona Ebner:
> Am 29.11.23 um 07:54 schrieb Hannes Laimer:
>> On 11/28/23 17:04, Fiona Ebner wrote:
>>> when editing a local sync job, the field would be empty because of
>>> this and not be set to the previously configured remote-store.
>>>
>> do you mean when opening the edit window of a local sync job, or when
>> switching between local/remote? If the former, it's a bug, but I wasn't
>> able to reproduce it. If the later, it won't be possible to keep it when
>> switching, the store field is the same field for local and remote, as in
>> the job config.
>>
>
> The former with proxmox-backup-server=3.0.5-1. Happens with both Firefox
> and Chromium for me.
As discussed off-list with Hannes, there already is a fix for this in
current master: fbee4799 ("ui: fix local sync job edit") and I
completely missed that this was the reason it worked rather than my
change when testing. So my change should be reverted, sorry about that!
prev parent reply other threads:[~2023-11-29 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 16:04 Fiona Ebner
2023-11-28 17:52 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-29 6:54 ` [pbs-devel] " Hannes Laimer
2023-11-29 7:42 ` Fiona Ebner
2023-11-29 8:02 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e75f1e38-2a2f-46d8-9351-f3ee0bf486af@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal