all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: [pbs-devel] applied: [PATCH] ui: filter partitions without proper UUID in partition selector
Date: Wed, 27 Nov 2024 20:19:00 +0100	[thread overview]
Message-ID: <e66674ed-b943-4c1b-bf1c-e600b423050d@proxmox.com> (raw)
In-Reply-To: <20241127151730.139984-1-h.laimer@proxmox.com>

Am 27.11.24 um 16:17 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  www/form/PartitionSelector.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/form/PartitionSelector.js b/www/form/PartitionSelector.js
> index 162dbe418..7ef542ffb 100644
> --- a/www/form/PartitionSelector.js
> +++ b/www/form/PartitionSelector.js
> @@ -8,7 +8,7 @@ Ext.define('pbs-partition-list', {
>  	    transform: (rawData) => rawData.data
>  		.flatMap(disk => (disk.partitions
>  			.map(part => ({ ...part, model: disk.model })) ?? [])
> -			.filter(partition => partition.used === 'filesystem')),
> +			.filter(partition => partition.used === 'filesystem' && !!partition.uuid)),
>  	},jj

^-- git am spotted this mishap as:

error: patch failed: www/form/PartitionSelector.js:8      
error: www/form/PartitionSelector.js: patch does not apply
error: Did you hand edit your patch?                      

I fixed that up and applied the patch, one needs to take care when editing
a patch directly, ideally it's avoided.

>      },
>      idProperty: 'devpath',



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      reply	other threads:[~2024-11-27 19:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27 15:17 [pbs-devel] " Hannes Laimer
2024-11-27 19:19 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e66674ed-b943-4c1b-bf1c-e600b423050d@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal