Re: [pmg-devel] [PATCH pmg-gui 1/1] spam quarantine: add columsn for positive/negative spam score matches

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 22.09.25 um 10:05 schrieb Dominik Csapak:
> The api returns the sum of spam matches individually for positive and
> negative ones, so add two new columns that show them. They each take up
> 50 pixels, so increase the width of the list by 100 pixel so we have the
> same space for the other columns here.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  js/SpamQuarantine.js | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js
> index 1844022..93c411d 100644
> --- a/js/SpamQuarantine.js
> +++ b/js/SpamQuarantine.js
> @@ -153,7 +153,7 @@ Ext.define('PMG.SpamQuarantine', {
>              selModel: 'checkboxmodel',
>              reference: 'list',
>              region: 'west',
> -            width: 500,
> +            width: 600,

The quarantine needs a relatively big viewport already as is, due to
navigation taking up a lot of unused space and the quarantine list
also needing space to show most useful info.

While the layout of the navigation might be something to reconsider
in the future, I'd probably not touch that now. But as each row in
the list spans over two rows anyway, we potentially could keep using
a single row column and put the +/- info both into a second row instead.

But IMO there is no pressure to look into that now, as due to lack of
feedback from others until now and PMG progressing towards a release
soonish at least I won't apply this now, there's always a next release.


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel