Re: [pve-devel] [PATCH] Patch for UTF8 encoding in Tools.pm

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 09/10/2024 um 02:45 schrieb James Brown:
> From 8ed0c20251c464a058ea08872bc7d54f6701d912 Mon Sep 17 00:00:00 2001
> From: James Brown <randomvoidmail@foxmail.com&gt;
> Date: Wed, 9 Oct 2024 08:40:10 +0800
> Subject: [PATCH] Add UTF8 encoding
> 

Please provide some actual commit message for why this is done, and evaluating
the actual fall out of the change.

> ---
> &nbsp;src/PVE/Tools.pm | 4 ++++
> &nbsp;1 file changed, 4 insertions(+)
> 
> 
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index bd305bd..cf86a0e 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -3,6 +3,10 @@ package PVE::Tools;
> &nbsp;use strict;
> &nbsp;use warnings;

the patch is broken, please submit it with a mail user agent that does not
messes with whitespace, if in doubt use git send-email [0].

[0]: https://git-send-email.io/
 
> +use open qw(:std :utf8);

that can have lots of fallout, or did you check all sites using PVE::Tools and
opening files to ensure that all definitively will write valid UTF-8 only?

> +use Encode qw(decode_utf8);
> +@ARGV = map { decode_utf8($_, 1) } @ARGV;

why are you re-encoding the system argument list in some library module?!
That is really a no-go, this must stay in the control of the actual executable.

> +
> &nbsp;use Date::Format qw(time2str);
> &nbsp;use Digest::MD5;
> &nbsp;use Digest::SHA;
> --
> 2.34.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel