From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v4 6/6] docs/api-viewer: improve rendering of array format
Date: Mon, 10 May 2021 17:08:43 +0200 [thread overview]
Message-ID: <e5b17836-99d7-7520-dd3b-45f960a199b1@proxmox.com> (raw)
In-Reply-To: <20210510092800.17956-7-d.csapak@proxmox.com>
On 10.05.21 11:28, Dominik Csapak wrote:
applied, with a small fix squashed in (see below), thanks!
> @@ -101,9 +97,28 @@ Ext.onReady(function() {
> return pdef.format;
>
> if (pdef.pattern)
> - return Ext.htmlEncode(pdef.pattern);
> + return pdef.pattern;
> +
> + if (pdef.type === 'boolean')
> + return `<true|false>`;
> +
> + if (type_fallback && pdef.type)
> + return `<${pdef.type}>`;
> +
> + return;
> + };
> +
> + let render_format = function(value, metaData, record) {
> + let pdef = record.data;
> +
> + metaData.style = 'white-space:normal;'
> +
> + if (pdef.type === 'array' && pdef.items) {
> + let format = render_simple_format(pdef.items, true);\f
FYI: Above line ended with a ^L (form feed), I amended the commit to drop that control character.
> + return `[${Ext.htmlEncode(format)}, ...]`;
> + }
>
> - return '';
> + return Ext.htmlEncode(render_simple_format(pdef) || '');
> };
>
> var real_path = function(path) {
>
prev parent reply other threads:[~2021-05-10 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 9:27 [pbs-devel] [PATCH proxmox-backup v4 0/6] tape: single snapshot restore Dominik Csapak
2021-05-10 9:27 ` [pbs-devel] [PATCH proxmox-backup v4 1/6] api2/tape/restore: refactor restore code into its own function Dominik Csapak
2021-05-10 9:27 ` [pbs-devel] [PATCH proxmox-backup v4 2/6] api2/tape/restore: add optional snapshots to 'restore' Dominik Csapak
2021-05-10 9:27 ` [pbs-devel] [PATCH proxmox-backup v4 3/6] tape/inventory: add completion helper for tape snapshots Dominik Csapak
2021-05-10 9:27 ` [pbs-devel] [PATCH proxmox-backup v4 4/6] bin/proxmox-tape: add optional snapshots to restore command Dominik Csapak
2021-05-10 9:27 ` [pbs-devel] [PATCH proxmox-backup v4 5/6] ui: tape: add single snapshot restore Dominik Csapak
2021-05-10 9:28 ` [pbs-devel] [PATCH proxmox-backup v4 6/6] docs/api-viewer: improve rendering of array format Dominik Csapak
2021-05-10 15:08 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5b17836-99d7-7520-dd3b-45f960a199b1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.