From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 common] REST environment: 'root@pam' fallback in task logs if no user specified for forked worker
Date: Wed, 16 Mar 2022 07:59:16 +0100 [thread overview]
Message-ID: <e512e85b-15c9-503e-db62-53f40c9b5a88@proxmox.com> (raw)
In-Reply-To: <20220315115239.636011-1-o.bektas@proxmox.com>
On 15.03.22 12:52, Oguz Bektas wrote:
> call sites without a defined user parameter (found only push_file and
> pull_file from pve-container) were logging the user as 'root@pve' which
> doesn't exist.
>
> for clarity, also add a comment that this is only used for the task
> logs.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v2->v3:
> * drop warning message
> * pass $noerr to get_user() to avoid dead code in case it fails
>
> src/PVE/RESTEnvironment.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, with slight adaptions to the commit message, thanks!
prev parent reply other threads:[~2022-03-16 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 11:52 [pve-devel] " Oguz Bektas
2022-03-16 6:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e512e85b-15c9-503e-db62-53f40c9b5a88@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal