From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4
Date: Thu, 18 Apr 2024 11:22:12 +0200 [thread overview]
Message-ID: <e4230f1a-b84a-4b28-b39f-8d8e714547bd@proxmox.com> (raw)
In-Reply-To: <1713429915.mrtg1ibixx.astroid@yuna.none>
Am 18/04/2024 um 10:48 schrieb Fabian Grünbichler:
> On April 18, 2024 10:17 am, Thomas Lamprecht wrote:
>> Am 11/04/2024 um 15:44 schrieb Fabian Grünbichler:
>>> if $storage && $format eq 'raw' => no noacl ?
>>
>> shouldn't this branch be taken if the format is _not_ raw, as only in that
>> case it might not use ext4?
>>
>
> if the format is raw (presumed ext4), don't set 'noacl'
> - I think that is correct? we want to avoid 'noacl' for ext4..
>
> note the double negation (no noacl) ;)
yeah, OK, the double negation got me confused here and in
Filip's v3, thanks for clearing this up.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-18 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 10:48 Filip Schauer
2024-04-11 13:44 ` Fabian Grünbichler
2024-04-17 14:38 ` Filip Schauer
2024-04-18 8:17 ` Thomas Lamprecht
2024-04-18 8:48 ` Fabian Grünbichler
2024-04-18 9:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4230f1a-b84a-4b28-b39f-8d8e714547bd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.