From: Filip Schauer <f.schauer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager] ui: lxc: add edit window for device passthrough
Date: Wed, 31 Jan 2024 16:14:10 +0100 [thread overview]
Message-ID: <e421b954-de67-4640-95c0-0c1894676163@proxmox.com> (raw)
In-Reply-To: <e450eedb-e938-40cf-99b5-2dd9d93de8a2@proxmox.com>
On 26/01/2024 16:23, Fiona Ebner wrote:
> I might be missing something, but isn't this a normal ExtJS text field?
> Does this cbind have any actual consequences? Same for the others.
This cbind is indeed not needed here.
A patch v3 that incorporates your feedback is available:
https://lists.proxmox.com/pipermail/pve-devel/2024-January/061578.html
prev parent reply other threads:[~2024-01-31 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 10:21 Filip Schauer
2024-01-26 15:23 ` Fiona Ebner
2024-01-29 14:32 ` Filip Schauer
2024-01-31 15:14 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e421b954-de67-4640-95c0-0c1894676163@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.