From: Dominik Csapak <d.csapak@proxmox.com>
To: Stefan Sterz <s.sterz@proxmox.com>,
pmg-devel@lists.proxmox.com,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: Re: [pmg-devel] [PATCH pmg-api v1] proxy: add support for switching themes
Date: Fri, 10 Mar 2023 11:14:14 +0100 [thread overview]
Message-ID: <e419d5cb-5612-cf19-880b-729e80355bff@proxmox.com> (raw)
In-Reply-To: <20230309080015.28615-1-s.sterz@proxmox.com>
replying here for the whole pmg part of the series
all in all LGTM
besides apart from some minor stuff that
can be done as a follow-up:
* in some parts the indentation is wrong
* the mobile quarantine has still white dialogs
(seems to be a bug in the framework7 version we use, updating
to a current version seems non-trivial since we're 3 major
versions behind, i can do it of course if wanted)
* regarding the quarantine theme toggle:
why should it not be possible to have a theme toggle when we respect the cookie?
we can just read the parameter and as a fallback rely on the cookie?
imho that would be a cleaner solution than inverting the whole mail
if these points are not a problem @Thomas/@Stoiko, consider the pmg part
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
next prev parent reply other threads:[~2023-03-10 10:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 16:18 [pve-devel] [PATCH widget-toolkit v1] Proxmox Dark Theme Stefan Sterz
2023-03-08 16:18 ` [pmg-devel] " Stefan Sterz
2023-03-08 16:18 ` [pbs-devel] " Stefan Sterz
2023-03-08 16:25 ` [pve-devel] " Stefan Sterz
2023-03-08 16:25 ` [pmg-devel] " Stefan Sterz
2023-03-08 16:25 ` [pbs-devel] " Stefan Sterz
2023-03-08 16:33 ` [pve-devel] [PATCH widget-toolkit v1 1/6] dark-theme: add initial version of the proxmox-dark theme Stefan Sterz
2023-03-08 16:33 ` [pmg-devel] " Stefan Sterz
2023-03-08 16:33 ` [pbs-devel] " Stefan Sterz
2023-03-08 16:36 ` [pve-devel] [PATCH widget-toolkit v1 2/6] subscription/summary/backup: stop setting the background color Stefan Sterz
2023-03-08 16:36 ` [pmg-devel] " Stefan Sterz
2023-03-08 16:36 ` [pbs-devel] " Stefan Sterz
2023-03-08 16:36 ` [pve-devel] [PATCH widget-toolkit v1 3/6] gauge widget: add support for a dark theme and dynamic theme switching Stefan Sterz
2023-03-08 16:36 ` [pmg-devel] " Stefan Sterz
2023-03-08 16:36 ` [pbs-devel] " Stefan Sterz
2023-03-08 16:36 ` [pve-devel] [PATCH widget-toolkit v1 4/6] rrd chart: add support for the " Stefan Sterz
2023-03-08 16:36 ` [pmg-devel] " Stefan Sterz
2023-03-08 16:36 ` [pbs-devel] " Stefan Sterz
2023-03-08 16:37 ` [pve-devel] [PATCH widget-toolkit v1 5/6] util/window/form: add a theme selector Stefan Sterz
2023-03-08 16:37 ` [pmg-devel] " Stefan Sterz
2023-03-08 16:37 ` [pbs-devel] " Stefan Sterz
2023-03-08 16:37 ` [pve-devel] [PATCH widget-toolkit v1 6/6] dark-theme: add support for the pmg quarantine theme toggle Stefan Sterz
2023-03-08 16:37 ` [pmg-devel] " Stefan Sterz
2023-03-08 16:37 ` [pbs-devel] " Stefan Sterz
2023-03-08 16:40 ` [pve-devel] [PATCH manager v1 1/4] gui: create user info menu intro for selecting the theme Stefan Sterz
2023-03-08 16:40 ` [pve-devel] [PATCH manager v1 2/4] pveproxy/template: add support for switching themes Stefan Sterz
2023-03-08 16:40 ` [pve-devel] [PATCH manager v1 3/4] subscription/summary/backup: stop setting the background color Stefan Sterz
2023-03-08 16:40 ` [pve-devel] [PATCH manager v1 4/4] ui: make ceph charts change color more dynamically Stefan Sterz
2023-03-08 16:40 ` [pve-devel] [PATCH docs v1] docs: add dark mode support to the api viewer Stefan Sterz
2023-03-08 17:05 ` [pve-devel] applied-series: [PATCH manager v1 1/4] gui: create user info menu intro for selecting the theme Thomas Lamprecht
2023-03-09 8:07 ` [pve-devel] Shell command and Emacs Lisp code injection in emacsclient-mail.desktop Stefan Sterz
2023-03-09 8:16 ` [pve-devel] applied-series: [PATCH manager v1 1/4] gui: create user info menu intro for selecting the theme Thomas Lamprecht
2023-03-09 8:29 ` Stefan Sterz
2023-03-08 16:41 ` [pbs-devel] [PATCH proxmox-backup v1 1/3] proxy/ui: implement theme switcher Stefan Sterz
2023-03-08 16:41 ` [pbs-devel] [PATCH proxmox-backup v1 2/3] ui: remove white backgrounds from package versions and system report Stefan Sterz
2023-03-14 16:56 ` [pbs-devel] applied: [PATCH proxmox-backup v1 1/3] proxy/ui: implement theme switcher Thomas Lamprecht
2023-03-08 16:43 ` [pbs-devel] [PATCH proxmox-backup v1 2/3] ui: remove white backgrounds from package versions and system report Stefan Sterz
2023-03-08 16:45 ` [pbs-devel] From 39998aadbf833c19a83fea3549105e625b029c50 Mon Sep 17 00:00:00 2001 Stefan Sterz
2023-03-08 16:51 ` Stefan Sterz
2023-03-08 17:04 ` [pve-devel] applied-series: [PATCH widget-toolkit v1] Proxmox Dark Theme Thomas Lamprecht
2023-03-08 17:04 ` [pmg-devel] applied-series: [pve-devel] " Thomas Lamprecht
2023-03-08 17:04 ` [pbs-devel] " Thomas Lamprecht
2023-03-09 8:00 ` [pmg-devel] [PATCH pmg-api v1] proxy: add support for switching themes Stefan Sterz
2023-03-10 10:14 ` Dominik Csapak [this message]
2023-03-10 10:24 ` Stefan Sterz
2023-03-15 15:42 ` [pmg-devel] applied: " Thomas Lamprecht
2023-03-09 8:00 ` [pmg-devel] [PATCH pmg-gui v1 1/6] mainview/quarantine: add theme switcher Stefan Sterz
2023-03-15 15:42 ` [pmg-devel] applied: " Thomas Lamprecht
2023-03-09 8:00 ` [pmg-devel] [PATCH pmg-gui v1 2/6] spam-info-grid: style the spam info grid via css variables Stefan Sterz
2023-03-09 8:01 ` [pmg-devel] [PATCH pmg-gui v1 3/6] subscription: remove hard-coded white background Stefan Sterz
2023-03-09 8:01 ` [pmg-devel] [PATCH pmg-gui v1 4/6] hourly mail distribution chart: add dynamic color switching Stefan Sterz
2023-03-09 8:01 ` [pmg-devel] [PATCH pmg-gui v1 5/6] mobile quarantine: add dark theme support to the mobile quarantine Stefan Sterz
2023-03-09 8:01 ` [pmg-devel] [PATCH pmg-gui v1 6/6] quarantines: add support for a theme toggle Stefan Sterz
2023-03-09 8:02 ` [pmg-devel] [PATCH pmg-docs v1] docs: add dark mode support to the api viewer Stefan Sterz
2023-03-23 16:11 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e419d5cb-5612-cf19-880b-729e80355bff@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
--cc=s.sterz@proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.