Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

[Stefan Sterz <s.sterz@proxmox.com>]

On 12/16/22 13:15, Fiona Ebner wrote:
> Am 15.12.22 um 17:57 schrieb Mira Limbeck:
>> diff --git a/PVE/Report.pm b/PVE/Report.pm
>> index 90b7cb1c..7ebe98f7 100644
>> --- a/PVE/Report.pm
>> +++ b/PVE/Report.pm
>> @@ -5,16 +5,34 @@ use warnings;
>>  
>>  use PVE::Tools;
>>  
>> +my sub file2text {
>> +    my ($file, $filter) = @_;
>> +    my $text = "\n# cat $file\n";
>> +
>> +    my $contents = PVE::Tools::file_get_contents($file);
>> +    if ($filter) {
>> +	foreach my $line (split('\n', $contents)) {
>> +	    next if $line =~ m/^\s*#/;
>> +	    next if $line =~ m/^cipassword/;
>> +
> Should we rather mask the value instead of dropping the whole line, so
> that we can see that /some/ cipassword is set? Might be more relevant
> for future filtered options.
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 

maybe somewhat off-topic for the patch at hand, but it might be nice to
modularize the pve report. so that `pvereport` gives you a default set
of information, but you could also use `pvereport ha` to give you more
information specifically about the state of the ha manager or `pvereport
ceph` for information about ceph etc.

maybe paired with a verbose flag so that you could request more detailed
info. e.g. `pvereport zfs` gives the zfs information currently in the
report, but `pvereport zfs -v` could also include `arc_summary` and `cat
/sys/module/zfs/parameters/zfs_arc_max` and other less often needed but
sometimes useful information.

this might be handy especially in cases where you need information that
spans several files/commands that aren't always needed. it might make
the `pvereport` more useful in the forum too, where we currently can't
use it at all because it discloses too much information.