From: Mira Limbeck <m.limbeck@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] file-restore: fix -blockdev regression with namespaces or encryption
Date: Tue, 10 Dec 2024 11:37:03 +0100 [thread overview]
Message-ID: <e227da29-9353-444b-b074-a94da8779503@proxmox.com> (raw)
In-Reply-To: <20241210093750.217116-1-f.gruenbichler@proxmox.com>
On 12/10/24 10:37, Fabian Grünbichler wrote:
> these two were missed because they were not part of the "main" format string..
>
> Fixes: 668b8383 ("file restore: qemu helper: switch to more modern blockdev option for drives")
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> proxmox-file-restore/src/qemu_helper.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-file-restore/src/qemu_helper.rs b/proxmox-file-restore/src/qemu_helper.rs
> index 1274dda35..e0e169110 100644
> --- a/proxmox-file-restore/src/qemu_helper.rs
> +++ b/proxmox-file-restore/src/qemu_helper.rs
> @@ -281,14 +281,14 @@ pub async fn start_vm(
> }
> drives.push("-blockdev".to_owned());
> let keyfile = if let Some(ref keyfile) = details.keyfile {
> - format!(",,keyfile={keyfile}")
> + format!(",keyfile={keyfile}")
> } else {
> "".to_owned()
> };
> let namespace = if details.namespace.is_root() {
> String::new()
> } else {
> - format!(",,namespace={}", details.namespace)
> + format!(",namespace={}", details.namespace)
> };
> drives.push(format!(
> "driver=pbs,repository={}{},snapshot={},archive={}{},read-only=on,node-name=drive{}",
Tested this in my cluster, makes the file restore VM start again.
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-12-10 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 9:37 Fabian Grünbichler
2024-12-10 10:37 ` Mira Limbeck [this message]
2024-12-10 11:08 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e227da29-9353-444b-b074-a94da8779503@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.