From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series-partially: [PATCH-SERIES v2 manager] ui: some backup job improvements
Date: Tue, 21 Sep 2021 15:31:20 +0200 [thread overview]
Message-ID: <e1df4f2b-f836-de9a-839b-210bd35830c9@proxmox.com> (raw)
In-Reply-To: <20210921112208.48084-1-f.ebner@proxmox.com>
On 21.09.21 13:22, Fabian Ebner wrote:
> The only thing remaining from v1 is adding a cluster-wide storage
> selector for the cluster-wide backup job editor.
>
> The new approach is to re-use the existing storage selector and add
> a config option to enable cluster-wide selection.
>
>
> Changes from v1:
> * Dropped already applied patches.
> * Extend existing storage selector to also support a cluster view
> instead of adding a new storage selector.
>
>
> pve-manager:
>
> Fabian Ebner (4):
> ui: storage selector: only check for nodename before loading storage
> ui: storage selector: add new clusterView option
> ui: cluster backup: only restrict storages to node when it's selected
> ui: storage selector: use storage type renderer
>
> www/manager6/dc/Backup.js | 4 +-
> www/manager6/form/StorageSelector.js | 109 +++++++++++++++++++++------
> 2 files changed, 88 insertions(+), 25 deletions(-)
>
applied all but the last one, I get where you come from but this is just to much
wasted space most of the time IMO, especially in the non-backup job cases, as there
we can never have a PBS and the other storage type names are all quite a bit shorter..
anyhow, thanks for the other stuff!
prev parent reply other threads:[~2021-09-21 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 11:22 [pve-devel] " Fabian Ebner
2021-09-21 11:22 ` [pve-devel] [PATCH v2 manager 1/4] ui: storage selector: only check for nodename before loading storage Fabian Ebner
2021-09-21 11:22 ` [pve-devel] [PATCH v2 manager 2/4] ui: storage selector: add new clusterView option Fabian Ebner
2021-09-21 11:22 ` [pve-devel] [PATCH v2 manager 3/4] ui: cluster backup: only restrict storages to node when it's selected Fabian Ebner
2021-09-21 11:22 ` [pve-devel] [PATCH v2 manager 4/4] ui: storage selector: use storage type renderer Fabian Ebner
2021-09-21 13:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1df4f2b-f836-de9a-839b-210bd35830c9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.