all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 1/3] ui: resource tree: fix nodes text moving in tree on update
Date: Thu, 23 Nov 2023 09:49:22 +0100	[thread overview]
Message-ID: <e1a68b5e-5b2f-4b35-aba3-8246f0f03c20@proxmox.com> (raw)
In-Reply-To: <20231123082542.872569-2-d.csapak@proxmox.com>

Am 23/11/2023 um 09:25 schrieb Dominik Csapak:
> when a node element was updated, it was put through the 'setText' method
> which accidentally added a space before it's name.
> 
> Fix this by putting the space into the status variable
> 
> This could be observed when one node had guests on it but others had not.
> The nodes would then be misaligned.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/tree/ResourceTree.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




  reply	other threads:[~2023-11-23  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23  8:25 [pve-devel] [PATCH manager 0/3] ui: small tree fixes Dominik Csapak
2023-11-23  8:25 ` [pve-devel] [PATCH manager 1/3] ui: resource tree: fix nodes text moving in tree on update Dominik Csapak
2023-11-23  8:49   ` Thomas Lamprecht [this message]
2023-11-23  8:25 ` [pve-devel] [PATCH manager 2/3] ui: resource tree: consistently apply the tooltip and 'setText' method Dominik Csapak
2023-11-23  8:25 ` [pve-devel] [PATCH manager 3/3] ui: resource tree: remove wrong comment Dominik Csapak
2023-11-23  8:49   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1a68b5e-5b2f-4b35-aba3-8246f0f03c20@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal