From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alwin Antreich <a.antreich@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager v2 1/5] ceph: split out pool set into own method
Date: Thu, 22 Oct 2020 18:52:00 +0200 [thread overview]
Message-ID: <e07a51bf-b69d-64c7-5467-b795ae7fe499@proxmox.com> (raw)
In-Reply-To: <20201019103934.1484472-1-a.antreich@proxmox.com>
On 19.10.20 12:39, Alwin Antreich wrote:
> to reduce code duplication and make it easier to add more options for
> pool commands.
>
> Use a new rados object for each 'osd pool set', as each command can set
> an option independent of the previous commands success/failure. On
> failure a new rados object would need to be created and that will
> confuse task tracking of the REST environment.
>
> Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
> ---
> Note:
> v1 -> v2:
> * reorder patches, since pool create & set share common pool
> options.
> * include new setpool API
>
> PVE/API2/Ceph.pm | 17 +++++++----
> PVE/Ceph/Tools.pm | 74 +++++++++++++++++++++++++----------------------
> 2 files changed, 52 insertions(+), 39 deletions(-)
>
>
applied series, thanks! FYI: Did a followup refactoring to the part where the defaults
are deleted conditionally in the common option method.
prev parent reply other threads:[~2020-10-22 16:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 10:39 [pve-devel] " Alwin Antreich
2020-10-19 10:39 ` [pve-devel] [PATCH manager v2 2/5] ceph: allow to alter pool settings Alwin Antreich
2020-10-19 10:39 ` [pve-devel] [PATCH manager v2 3/5] ceph: use pool common options pool create Alwin Antreich
2020-10-19 10:39 ` [pve-devel] [PATCH manager v2 4/5] ceph: add pg_autoscale_mode to " Alwin Antreich
2020-10-19 10:39 ` [pve-devel] [PATCH manager v2 5/5] ceph: gui: add autoscale mode " Alwin Antreich
2020-10-22 16:52 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e07a51bf-b69d-64c7-5467-b795ae7fe499@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.antreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.