From: Gabriel Goller <g.goller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/2] lxc: show IPs in summary view
Date: Fri, 6 Dec 2024 10:44:08 +0100 [thread overview]
Message-ID: <dy5maegvmqya52whfu4fofn72mgvhowxodoppo6rdpcf46t4jj@5qw4hfa5aepy> (raw)
In-Reply-To: <11531312-7635-451b-9ebf-58f08a95821c@proxmox.com>
On 04.12.2024 10:25, Dominik Csapak wrote:
>high level comments/questions (i know they're not you're patches exactly, but still):
>
>* maybe it would be better to integrate this into the AgentIPView for vms?
> AFAICS the code is very similar and probably just needs a few adaptions
> to work there too (url,parsing, etc.)
>
> I'm not opposed to have two components, but then we should at least have
> a good reason in the commit message why this was not done, e.g.
> the data structures are too different, or something like that
>
>* IMHO we should keep the columns consistent between VMs and Containers,
> So either we change the AgentIPView to name/mac/ipv4/ipv6 too
> or we combine the ipv4/ipv6 here
Oh, and yes I combined ipv4 and ipv6 here + aligned the popup to be
more similar to the AgentView.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-06 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 10:46 [pve-devel] [PATCH manager 0/2] Show container ip in summary and network tab Gabriel Goller
2024-12-02 10:46 ` [pve-devel] [PATCH manager 1/2] lxc: show dynamically assigned IPs in " Gabriel Goller
2024-12-04 9:17 ` Dominik Csapak
2024-12-04 9:52 ` Gabriel Goller
2024-12-04 10:10 ` Dominik Csapak
2024-12-04 10:45 ` Gabriel Goller
2024-12-02 10:46 ` [pve-devel] [PATCH manager 2/2] lxc: show IPs in summary view Gabriel Goller
2024-12-04 9:25 ` Dominik Csapak
2024-12-05 17:28 ` Gabriel Goller
2024-12-06 12:45 ` Dominik Csapak
2024-12-06 9:44 ` Gabriel Goller [this message]
2024-12-10 15:08 ` [pve-devel] [PATCH manager 0/2] Show container ip in summary and network tab Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dy5maegvmqya52whfu4fofn72mgvhowxodoppo6rdpcf46t4jj@5qw4hfa5aepy \
--to=g.goller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.