all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Mira Limbeck <m.limbeck@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-openid-rs] fix Open ID with Azure as provider
Date: Fri, 1 Apr 2022 10:57:49 +0200	[thread overview]
Message-ID: <df61c357-c18d-da32-2643-3830aee70da8@proxmox.com> (raw)
In-Reply-To: <287966750.23.1648786881113@webmail.proxmox.com>

On 4/1/22 06:21, Dietmar Maurer wrote:
>>       let response = if let Method::POST = request.method {
>> -        req.send(&*request.body)
>> +        let bytes = request.body.as_slice();
>> +        req.send_bytes(bytes)
> Does this have the side effect of changing the transfer encoding? If so, it is worth to add an inline comment.

This makes sure that `Transfer-Encoding` is not set at all, but instead 
`Content-Length` is set.

AFAIK either one of those is required, but not both at the same time. 
And some endpoints don't seem to accept `Transfer-Encoding: chunked`.

I'll add an inline comment mentioning that, thanks!





  reply	other threads:[~2022-04-01  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01  4:21 Dietmar Maurer
2022-04-01  8:57 ` Mira Limbeck [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-31 13:33 Mira Limbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df61c357-c18d-da32-2643-3830aee70da8@proxmox.com \
    --to=m.limbeck@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal