all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: yew-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: applied: [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 0/4] adaptive scaffold/navigation rail improvements
Date: Mon, 31 Aug 2026 18:18:20 +0200	[thread overview]
Message-ID: <df52cfaa-74cf-4142-ba83-1ddba963994e@proxmox.com> (raw)
In-Reply-To: <178819046850.2713229.15946885246003395028.b4-ty@b4>

Am 31.08.26 um 18:14 schrieb Thomas Lamprecht:
> On Mon, 10 Aug 2026 16:34:50 +0200, Dominik Csapak wrote:
>> Move the automatic expand/collapse logic to the navigation rail
>> and add an (opt-in) button there too for activating it manually.
>>
>> Also add a pass-through option for the rail group alignment there.
>>
>> Possible future work:
>>
>> [...]
> 
> Applied, thanks! Folded some changes in (noted in the commit message's trailer
> section), mainly:
> - made responsive rail expansion opt-in so standalone rails do not
>   unexpectedly require more layout space; AdaptiveScaffold opts in
> - retained `expanded` as the fixed-layout boolean, separate from automatic
>   mode
> - kept manual overrides until their active layout source changes
> - reworded the commit messages and API documentation to match these changes.

small correction to my note above (I got side-tracked and read the
range-diff output wrong without rechecking, sorry!): replacing large_query
with rail_expanded_query and separating navigator selection from rail
expansion were already part of Dominik's original patch.

My changes made automatic expansion opt-in, retained expanded for the fixed
layout, and adapted the toggle handling and documentation. Sorry for the
wrong attribution.




      reply	other threads:[~2026-08-31 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 14:34 [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 0/4] adaptive scaffold/navigation rail improvements Dominik Csapak
2026-08-10 14:34 ` [PATCH yew-widget-toolkit-assets 1/4] navigation rail: style the expand button Dominik Csapak
2026-08-10 14:34 ` [PATCH yew-widget-toolkit 2/4] touch: navigation rail: move auto layout from AdaptiveScaffold Dominik Csapak
2026-08-10 14:34 ` [PATCH yew-widget-toolkit 3/4] touch: navigation rail: add an optional expand button Dominik Csapak
2026-08-10 14:34 ` [PATCH yew-widget-toolkit 4/4] touch: adaptive scaffold: pass the rail group alignment through Dominik Csapak
2026-08-31 15:34 ` applied: [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 0/4] adaptive scaffold/navigation rail improvements Thomas Lamprecht
2026-08-31 16:18   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df52cfaa-74cf-4142-ba83-1ddba963994e@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal