From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 8962E1FF09B for ; Mon, 31 Aug 2026 18:18:23 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 53B41212E1; Mon, 31 Aug 2026 18:18:23 +0200 (CEST) Message-ID: Date: Mon, 31 Aug 2026 18:18:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: applied: [PATCH yew-widget-toolkit/yew-widget-toolkit-assets 0/4] adaptive scaffold/navigation rail improvements From: Thomas Lamprecht To: yew-devel@lists.proxmox.com, Dominik Csapak References: <20260810143536.31163-1-d.csapak@proxmox.com> <178819046850.2713229.15946885246003395028.b4-ty@b4> Content-Language: en-US In-Reply-To: <178819046850.2713229.15946885246003395028.b4-ty@b4> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788193086749 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.928 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7KLNKJMYV5EY7QNAI5K23O7AS4MATCJK X-Message-ID-Hash: 7KLNKJMYV5EY7QNAI5K23O7AS4MATCJK X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 31.08.26 um 18:14 schrieb Thomas Lamprecht: > On Mon, 10 Aug 2026 16:34:50 +0200, Dominik Csapak wrote: >> Move the automatic expand/collapse logic to the navigation rail >> and add an (opt-in) button there too for activating it manually. >> >> Also add a pass-through option for the rail group alignment there. >> >> Possible future work: >> >> [...] > > Applied, thanks! Folded some changes in (noted in the commit message's trailer > section), mainly: > - made responsive rail expansion opt-in so standalone rails do not > unexpectedly require more layout space; AdaptiveScaffold opts in > - retained `expanded` as the fixed-layout boolean, separate from automatic > mode > - kept manual overrides until their active layout source changes > - reworded the commit messages and API documentation to match these changes. small correction to my note above (I got side-tracked and read the range-diff output wrong without rechecking, sorry!): replacing large_query with rail_expanded_query and separating navigator selection from rail expansion were already part of Dominik's original patch. My changes made automatic expansion opt-in, retained expanded for the fixed layout, and adapted the toggle handling and documentation. Sorry for the wrong attribution.