* [pve-devel] [PATCH pve-network] network: add|del_fdb: fix learning check
@ 2022-11-21 9:54 Alexandre Derumier
2022-11-21 10:23 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Derumier @ 2022-11-21 9:54 UTC (permalink / raw)
To: pve-devel
ovs port don't have sysfs path
"/sys/class/net/$iface/brport/learning"
We need to check if the value is undef too
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
src/PVE/Network.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm
index 26d8cb1..d1d2e5e 100644
--- a/src/PVE/Network.pm
+++ b/src/PVE/Network.pm
@@ -300,7 +300,7 @@ sub add_bridge_fdb {
my ($iface, $mac) = @_;
my $learning = PVE::Tools::file_read_firstline("/sys/class/net/$iface/brport/learning");
- return if $learning;
+ return if !defined($learning) || $learning == 1;
my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
return if !defined($vmid);
@@ -320,7 +320,7 @@ sub del_bridge_fdb {
my ($iface, $mac) = @_;
my $learning = PVE::Tools::file_read_firstline("/sys/class/net/$iface/brport/learning");
- return if $learning;
+ return if !defined($learning) || $learning == 1;
my ($vmid, $devid) = &$parse_tap_device_name($iface, 1);
return if !defined($vmid);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH pve-network] network: add|del_fdb: fix learning check
2022-11-21 9:54 [pve-devel] [PATCH pve-network] network: add|del_fdb: fix learning check Alexandre Derumier
@ 2022-11-21 10:23 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-21 10:23 UTC (permalink / raw)
To: Proxmox VE development discussion, Alexandre Derumier
Am 21/11/2022 um 10:54 schrieb Alexandre Derumier:
> ovs port don't have sysfs path
> "/sys/class/net/$iface/brport/learning"
>
> We need to check if the value is undef too
>
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
> src/PVE/Network.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-21 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 9:54 [pve-devel] [PATCH pve-network] network: add|del_fdb: fix learning check Alexandre Derumier
2022-11-21 10:23 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.