all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-ebpf v5 0/5] add proxmox-ebpf library
Date: Tue, 3 Nov 2026 10:23:08 +0100	[thread overview]
Message-ID: <de24d4e7-fc9a-43ed-9ead-b51a7171e763@proxmox.com> (raw)
In-Reply-To: <7826f3d1-4f90-411c-ba45-8bff7ef8a214@proxmox.com>

Am 03.11.26 um 09:58 schrieb Hannes Laimer:
> On 2026-11-02 21:19, Thomas Lamprecht wrote:
>> Am 02.11.26 um 16:09 schrieb Hannes Laimer:
>>> The series applies on top of the scaffolding commit of the repo, which
>>> is not on the list since it carries the vendored vmlinux.h at ~167k
>>> lines. It is on my staff repo along with these five commits.
>>
>> So that's basically the reasoning to not put this inside the common
>> proxmox workspace I guess? FWIW; the header is quite nicely tracked
>> in git and as long as we do not have to highly frequently update it,
>> putting this inside proxmox workspace might be a nicer trade-of
>> compared to a dedicated repo.
>>
> 
> the reason was mostly because I had this as a binary(kind of like the
> fw) in the beginning, I just didn't really consider moving it there
> since. the only thing is that this is the first using clang in its
> build.rs, so we'd need clang, libbpf-dev and linux-libc-dev as deps for
> the workspace. don't think that should be a problem though

Not for the workspace, each crate dir has its own packaging, i.e. those
are all different source packages. But we indeed do not have any other
"real" binary package, as in non-librust-source-code one. Can we host
this in proxmox-firewall or maybe even better pve-network as its own
source package there? Else fine to have its own repo I guess, it's a bit
a matter of taste (I do not want a single mono repo, but also not
spreading stuff over to man single one, a bit grouped by topic would be
nice).

Cc'in Fabian and Stefan/Gabriel for packaging and SDN preference here.

>> Oh, and why can't we depend on a proxmox-headers package on build?
>> Like on proxmox-headers-7.0.14-28-pve? that would allow full control
>> without checking the headers file in. Or can't that work or is that
>> not a good fit
> 
> we don't really use kernel internal stuff, and we probably also won't(or
> should not) in the future. so the huge vmlinux.h can actually go, but we
> also don't need proxmox-headers, this is userspace, we shouldn't need
> version specific things

user space can also need (newer) changes I guess. For user space we
got proxmox-kernel-libc-dev - is that enough then?

> 
> ill prepare a v6 moving it into the proxmox workspace.
> thanks for taking a look! :)





  reply	other threads:[~2026-11-03  9:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 15:00 [PATCH proxmox-ebpf v5 0/5] add proxmox-ebpf library Hannes Laimer
2026-11-02 15:00 ` [PATCH proxmox-ebpf v5 1/5] tc: add the link plumbing Hannes Laimer
2026-11-02 15:00 ` [PATCH proxmox-ebpf v5 2/5] subsystem: add the shared tc program handling Hannes Laimer
2026-11-02 15:00 ` [PATCH proxmox-ebpf v5 3/5] subsystem: place the links of different subsystems in a fixed order Hannes Laimer
2026-11-02 15:00 ` [PATCH proxmox-ebpf v5 4/5] tests: add a native harness for the BPF C programs Hannes Laimer
2026-11-02 15:00 ` [PATCH proxmox-ebpf v5 5/5] debian: package the crate as a Rust library Hannes Laimer
2026-11-02 20:19 ` [PATCH proxmox-ebpf v5 0/5] add proxmox-ebpf library Thomas Lamprecht
2026-11-03  8:58   ` Hannes Laimer
2026-11-03  9:23     ` Thomas Lamprecht [this message]
2026-11-03  9:48       ` Hannes Laimer
2026-11-04 10:30         ` Fabian Grünbichler
2026-11-04 11:27           ` Hannes Laimer
2026-11-04 11:34             ` Stefan Hanreich
2026-11-04 11:50               ` Thomas Lamprecht
2026-11-04 12:36                 ` Stefan Hanreich
2026-11-04 13:50 ` superseded: " Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de24d4e7-fc9a-43ed-9ead-b51a7171e763@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal