Re: [PATCH proxmox-ebpf v5 0/5] add proxmox-ebpf library

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 11/4/26 12:50 PM, Thomas Lamprecht wrote:
> Am 04.11.26 um 12:34 schrieb Stefan Hanreich:
>>> proxmox-firewall is built mostly around the firewall binary, and this is
>>> really scoped towards just PVEs SDN, proxmox-ve-rs is probably the best
>>> fit here, since proxmox mostly contains non-product-specific code
> 
> In the mid/long-term proxmox-firewall should provide basic firewalling for
> all our products, inclusive basic shared api/ui integrations. How exactly
> that's structured doesn't have to be defined now, but I'd not see the whole
> firewall area as PVE-only, most of its (more complex) use case might be only
> sensible for PVE, but the basics should be shared.

Agree, that's part of the reason why I wanted to move everything into the
firewall crate at least.
 
>> I was also thinking about ve-rs. In short/mid-term I'm not sure if we
>> shouldn't just move all the firewall related parts from ve-rs to proxmox
>> or proxmox-firewall completely. That'd leave us with the SDN specific
>> stuff here and we could potentially turn that into a proxmox-sdn workspace?
>> But I'm unsure if we want to add further crates there that deal with other,
>> non-SDN stuff or where those would go then?
> 
> proxmox workspace is fine for this here, and if not really PVE specific (on
> initial introduction and somewhat foreseeable future) I'd also favor that
> for new lib crates in general.
> 
> SDN can be somewhat carved out and could be its own repo with a bunch of
> crates if desired and I have nothing against that if you, Gabriel, Hannes,
> ... see a strong benefit in it. In the end it still needs to produce the
> librust- packaged source code crates and also those that allow PVE, PDM,
> ...? usage and integration nicely, so it doesn't change much - which OTOH
> is also a point for just doing it in proxmox and save a separate repo. We
> can also add a sdn/ folder there to bundle the crates and keep it more
> organized FWIW.

Yeah, moving to to proxmox is fine by me - not sure if we even need a
separate subfolder. That'd then eliminate proxmox-ve-rs completely. It'd
also make building / maintaining the whole stack easier afaict?