From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ios: include the `NSFaceIDUsageDescription` in info.plist
Date: Wed, 16 Jul 2025 15:13:11 +0200 [thread overview]
Message-ID: <de1a82bf-e063-4b74-a26b-0f2f6fb66693@proxmox.com> (raw)
In-Reply-To: <20250513103200.50867-1-s.shaji@proxmox.com>
LGTM.
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 2025-05-13 12:32, Shan Shaji wrote:
> The app was crashing on iOS when trying to access the biometric storage
> to access the saved password. The crash was due to a missing key inside
> the `Info.plist` file [0]. This patch fixes it by adding the missing
> `NSFaceIDUsageDescription` key inside the `Info.plist` file.
>
> - [0]
> https://developer.apple.com/documentation/bundleresources/information-property-list/nsfaceidusagedescription
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
> ios/Runner/Info.plist | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ios/Runner/Info.plist b/ios/Runner/Info.plist
> index ef3f061..825d78d 100644
> --- a/ios/Runner/Info.plist
> +++ b/ios/Runner/Info.plist
> @@ -24,6 +24,8 @@
> <string>$(FLUTTER_BUILD_NUMBER)</string>
> <key>LSRequiresIPhoneOS</key>
> <true/>
> + <key>NSFaceIDUsageDescription</key>
> + <string>Use Face ID for a faster and more convenient login experience.</string>
> <key>UILaunchStoryboardName</key>
> <string>LaunchScreen</string>
> <key>UIMainStoryboardFile</key>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-16 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 10:32 Shan Shaji
2025-07-14 13:01 ` Shan Shaji
2025-07-16 13:13 ` Aaron Lauterer [this message]
2025-07-16 13:24 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1a82bf-e063-4b74-a26b-0f2f6fb66693@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.