From: alexandre derumier <aderumier@odiso.com>
To: "pve-user@pve.proxmox.com" <pve-user@pve.proxmox.com>
Subject: [PVE-User] qemu-server: bug in vmconfig_apply_pending errors handling
Date: Sun, 04 Jul 2021 19:29:20 +0200 [thread overview]
Message-ID: <de12f7af7f8d4644e02e2f13cd4c7bb156cf7be9.camel@odiso.com> (raw)
Hi,
I'm still working on ipam support for qemu-server,
I have notice a bug in error handling of offline change apply, since
commit
https://git.proxmox.com/?p=qemu-server.git;a=commit;h=eb5e482ded9ae6aeb6575de9441b79b90a5de531
introduce $errors support
API2/Qemu.pm
-
PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $
storecfg, $running);
+ PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $
storecfg, $running, $errors);
PVE/QemuServer.pm
sub vmconfig_apply_pending {
- my ($vmid, $conf, $storecfg) = @_;
+ my ($vmid, $conf, $storecfg, $errors) = @_;
The problem is the $running param used, not existing in the sub.
reply other threads:[~2021-07-04 17:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de12f7af7f8d4644e02e2f13cd4c7bb156cf7be9.camel@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-user@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.