From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix #4166: restore: add resource pool selector
Date: Wed, 21 May 2025 14:36:18 +0200 [thread overview]
Message-ID: <de11b26b-c82a-43c2-a748-742fd9229780@proxmox.com> (raw)
In-Reply-To: <20250430104543.272091-1-m.sandoval@proxmox.com>
Am 30.04.25 um 12:45 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> www/manager6/window/Restore.js | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
> index 22900868..8d6dfabe 100644
> --- a/www/manager6/window/Restore.js
> +++ b/www/manager6/window/Restore.js
> @@ -47,6 +47,9 @@ Ext.define('PVE.window.Restore', {
> if (values.storage) {
> params.storage = values.storage;
> }
> + if (values.pool) {
> + params.pool = values.pool;
> + }
>
> ['bwlimit', 'cores', 'name', 'memory', 'sockets'].forEach(opt => {
> if ((values[opt] ?? '') !== '') {
> @@ -186,6 +189,13 @@ Ext.define('PVE.window.Restore', {
> fieldLabel: gettext('Source'),
> },
> storagesel,
> + {
> + xtype: 'pvePoolSelector',
> + fieldLabel: gettext('Resource Pool'),
> + name: 'pool',
> + value: '',
> + allowBlank: true,
In case of an in-place restore, the pool option does not have any
effect, so the selector should be hidden. And pre-existing, but the
backend should print a message/warning that the parameter is ignored.
> + },
> {
> xtype: 'pmxDisplayEditField',
> name: 'vmid',
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-05-21 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 10:45 Maximiliano Sandoval
2025-05-21 12:36 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de11b26b-c82a-43c2-a748-742fd9229780@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal