From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage 2/3] convert maxfiles to prune_backups when reading the storage configuration
Date: Mon, 23 Nov 2020 15:58:07 +0100 [thread overview]
Message-ID: <ddf00fd5-1680-1434-8321-67900a43fbd9@proxmox.com> (raw)
In-Reply-To: <20201123123310.13898-2-f.ebner@proxmox.com>
On 23.11.20 13:33, Fabian Ebner wrote:
> If there are already prune options configured, simply delete the maxfiles
> setting. Having set both is invalid from vzdump's perspective anyways, and any
> backup job on such a storage failed, meaning a user would've noticed.
>
> If there are no prune options, translate the maxfiles value to keep-last,
> except for maxfiles being zero (=unlimited), in which case we use keep-all.
>
> If both are not set, don't set anything, so:
> 1. Storages don't suddenly have retention options set.
> 2. People relying on vzdump defaults can still use those.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage.pm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
>
applied, thanks!
next prev parent reply other threads:[~2020-11-23 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 12:33 [pve-devel] [PATCH storage 1/3] prune: introduce keep-all option Fabian Ebner
2020-11-23 12:33 ` [pve-devel] [PATCH storage 2/3] convert maxfiles to prune_backups when reading the storage configuration Fabian Ebner
2020-11-23 14:58 ` Thomas Lamprecht [this message]
2020-11-23 12:33 ` [pve-devel] [PATCH manager 3/3] vzdump: adapt to new keep-all prune option Fabian Ebner
2020-11-23 14:58 ` [pve-devel] applied: [PATCH storage 1/3] prune: introduce keep-all option Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddf00fd5-1680-1434-8321-67900a43fbd9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.